Fix sky radiance texunit in compatibility renderer#114767
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Jan 26, 2026
Merged
Fix sky radiance texunit in compatibility renderer#114767Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
AThousandShips
changed the title
clayjohn
approved these changes
Jan 9, 2026
Member
clayjohn
left a comment
clayjohn
left a comment
There was a problem hiding this comment.
Looks good.
Indeed the half and quarter res textures are only partially implementation and currently cause a shader compilation error if you try to use them. So they can be ignored for now since they don't work anyway
Contributor
|
Thanks! Congratulations on your first merged contribution! 🎉 |
rivie13
pushed a commit
to rivie13/Phoenix-Agentic-Engine
that referenced
this pull request
Feb 16, 2026
…-wrong-texunit Fix sky radiance texunit in compatibility renderer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #114606: Reading radiance in sky shader in compatibility mode does not work
Aligned texunit in shader to binding. See drivers/gles3/rasterizer_scene_gles3.cpp / _render_list_template:
Please note that I did not know what to do with half_res and quarter_res -- most likely they are also wrong or even not available in compatibility.